reta commented on code in PR #2062:
URL: https://github.com/apache/cxf/pull/2062#discussion_r1755249129
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java:
##########
@@ -59,12 +62,15 @@ protected AbstractOpenTelemetryClientProvider(final
OpenTelemetry openTelemetry,
protected TraceScopeHolder<TraceScope> startTraceSpan(final Map<String,
List<String>> requestHeaders,
URI uri, String
method) {
Context parentContext = Context.current();
- Span activeSpan =
tracer.spanBuilder(buildSpanDescription(uri.toString(), method))
- .setParent(parentContext).setSpanKind(SpanKind.CLIENT)
- .setAttribute(HttpAttributes.HTTP_REQUEST_METHOD, method)
- .setAttribute(UrlAttributes.URL_FULL, uri.toString())
- // TODO: Enhance with semantics from request
- .startSpan();
+ Span activeSpan =
tracer.spanBuilder(buildSpanDescription(uri.getPath(), method))
Review Comment:
Please preserve the span name, it is uniform across CXF tracing integrations:
```suggestion
Span activeSpan =
tracer.spanBuilder(buildSpanDescription(uri.toString(), method))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
