Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/223#discussion_r30825223
  
    --- Diff: cordova-lib/src/cordova/platform.js ---
    @@ -122,6 +122,12 @@ function addHelper(cmd, hooksRunner, projectRoot, 
targets, opts) {
                             if (platformAlreadyAdded) {
                                 throw new CordovaError('Platform ' + platform 
+ ' already added.');
                             }
    +
    +                        // Remove the <platform>.json file from the 
plugins directory, so we start clean (otherwise we
    +                        // can get into trouble not installing plugins if 
someone deletes the platform folder but
    +                        // <platform>.json still exists).
    +                        removePlatformPluginsJson(projectRoot, target);
    --- End diff --
    
    Fair points! LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to