Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/223#discussion_r30792008
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -122,6 +122,12 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
if (platformAlreadyAdded) {
throw new CordovaError('Platform ' + platform
+ ' already added.');
}
+
+ // Remove the <platform>.json file from the
plugins directory, so we start clean (otherwise we
+ // can get into trouble not installing plugins if
someone deletes the platform folder but
+ // <platform>.json still exists).
+ removePlatformPluginsJson(projectRoot, target);
--- End diff --
I think this function call should be moved to
https://github.com/MSOpenTech/cordova-lib/blob/CB-9051/cordova-lib/src/cordova/platform.js#L174,
because the 'addHelper' function is used both by the 'cordova platform add'
and 'cordova platform update'. and it is our intention to only do this file
deletion when we are performing an 'add' operation.
Another reason might be that we should be doing this file deletion close to
the 'installPluginsForTheNewPlatform' function call, to minimize the risk of
getting in an inconsistent state where the file has already been deleted even
though the 'add' operation ends up throwing an exception down the line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
