Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/223#discussion_r30817164
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -122,6 +122,12 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
if (platformAlreadyAdded) {
throw new CordovaError('Platform ' + platform
+ ' already added.');
}
+
+ // Remove the <platform>.json file from the
plugins directory, so we start clean (otherwise we
+ // can get into trouble not installing plugins if
someone deletes the platform folder but
+ // <platform>.json still exists).
+ removePlatformPluginsJson(projectRoot, target);
--- End diff --
Regarding your first point: If you look at the context of where the call
was added, it is within an `if (cmd == 'add')` check.
Regarding your second point - no, we still want the file deleted even if
the `add` operation fails. Essentially we're just putting things into the state
they would have been in if the platform had been properly removed, so we want
to get into that state as early as possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
