On Wed, Oct 29, 2025 at 4:32 AM Gary Gregory <[email protected]> wrote:
> -1, I like to keep it simple. > +1 to Gary's -1. Here is a thought experiment: Imagine how much "better" our software would be if we forced ggregory and markt (the ones who have said -1 to this proposal) to add the proposed steps to their workflows. > > Logj4 is has lost involvement from key contributors and is slowly dying on > the vine IMO due to all of of the hoops and requests it makes on > contributions. > > > Enable auto-merge > That one takes the cake, nothing should ever be auto-merged. > Ridiculous. Please no, especially not the bot slop. > > Gary > > > On Wed, Oct 29, 2025, 06:35 Piotr P. Karwasz <[email protected]> > wrote: > > > Hi all, > > > > I’d like to propose enabling branch protection rules for the Commons > > repositories while still preserving our Commit-Then-Review workflow. > > > > Specifically, we could enable the following GitHub settings: > > > > - Require a pull request before merging > > - No required approvals: PR authors can merge their own changes, even > > seconds after the creation of the PR > > - Require status checks to pass before merging > > - Enable auto-merge to queue merges, instead of waiting for the required > > status checks to pass > > - Use only “Squash merge” to keep history linear and avoid noise like > > “fix previous commit” messages > > > > I realize this introduces a small amount of process overhead (Byzantine > > bureaucracy), but it would bring a few benefits: > > > > - Creates an audit trail for reviews > > Even after merge, comments can be used to record approvals. This also > > lets us search for PRs without comments to identify code that still > > needs review, so we don't need to review each commit 44 times. > > > > - Prevents accidental breakage > > Required checks ensure we don’t merge commits that break the build. > > > > - Improves notifications > > GitHub doesn’t support commit notifications, but it does notify on PRs > > letting contributors follow only the repositories they care about > > instead of filtering `commits@commons`. > > > > Piotr > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > >
