+1 I'd still prefer RTC but this seems like a distinct improvement. At least there'd be no more hidden commits that aren't shown in the PR history.
On Wed, Oct 29, 2025 at 10:35 AM Piotr P. Karwasz <[email protected]> wrote: > > Hi all, > > I’d like to propose enabling branch protection rules for the Commons > repositories while still preserving our Commit-Then-Review workflow. > > Specifically, we could enable the following GitHub settings: > > - Require a pull request before merging > - No required approvals: PR authors can merge their own changes, even > seconds after the creation of the PR > - Require status checks to pass before merging > - Enable auto-merge to queue merges, instead of waiting for the required > status checks to pass > - Use only “Squash merge” to keep history linear and avoid noise like > “fix previous commit” messages > > I realize this introduces a small amount of process overhead (Byzantine > bureaucracy), but it would bring a few benefits: > > - Creates an audit trail for reviews > Even after merge, comments can be used to record approvals. This also > lets us search for PRs without comments to identify code that still > needs review, so we don't need to review each commit 44 times. > > - Prevents accidental breakage > Required checks ensure we don’t merge commits that break the build. > > - Improves notifications > GitHub doesn’t support commit notifications, but it does notify on PRs > letting contributors follow only the repositories they care about > instead of filtering `commits@commons`. > > Piotr > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > -- Elliotte Rusty Harold [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
