rhenwood-arm commented on a change in pull request #91: run time support is added for openssl 1.0 and 1.1 for UNIX URL: https://github.com/apache/commons-crypto/pull/91#discussion_r255216767
########## File path: src/main/native/org/apache/commons/crypto/cipher/OpenSslNative.c ########## @@ -49,6 +50,8 @@ static EVP_CIPHER * (*dlsym_EVP_aes_128_cbc)(void); static EVP_CIPHER * (*dlsym_EVP_aes_256_gcm)(void); static EVP_CIPHER * (*dlsym_EVP_aes_192_gcm)(void); static EVP_CIPHER * (*dlsym_EVP_aes_128_gcm)(void); +static void *openssl_old, *openssl_new; +static int openssl_1 = 0, openssl_0 = 0; Review comment: Please consider if these variable names be improved. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
