rhenwood-arm commented on a change in pull request #91: run time support is added for openssl 1.0 and 1.1 for UNIX URL: https://github.com/apache/commons-crypto/pull/91#discussion_r255217195
########## File path: src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c ########## @@ -55,6 +55,8 @@ static int (*dlsym_ENGINE_free) (ENGINE *); static void (*dlsym_ENGINE_cleanup) (void); static int (*dlsym_RAND_bytes) (unsigned char *, int); static unsigned long (*dlsym_ERR_get_error) (void); +static int openssl_1 = 0, openssl_0 = 0; Review comment: I would prefer more specific variable names, like openssl_1_0, and openssl_1_1 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
