rhenwood-arm commented on a change in pull request #91: run time support is added for openssl 1.0 and 1.1 for UNIX URL: https://github.com/apache/commons-crypto/pull/91#discussion_r255215704
########## File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c ########## @@ -41,7 +41,10 @@ #ifdef UNIX static unsigned long (*dlsym_SSLeay) (void); static char * (*dlsym_SSLeay_version) (int); -static void *openssl; +static unsigned long (*dlsym_OpenSSL_version_num) (void); +static char * (*dlsym_OpenSSL_version) (int); +static void *openssl_old, *openssl_new; +static int openssl_1 = 0, openssl_0 = 0; Review comment: I suggest more explicit names: openssl_1_0 openssl_1_1. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
