Good effort, Sergio! Sorry for late review. I guess you didn't get to many replies as there was confusion with the dist/svn revision.. :-(
Sorry, my vote is -1 (binding) .. as META-INF/LICENSE and META-INF/NOTICE are missing in the binary JARs in the maven repo. (Not sure how I missed this before, is this caused by a change in commons-parent affecting submodules?) +1 gpg signatures dist & staging +1 dist svn (revision 23205 and 23227 are equal in this subtree) +1 git commit == tag ~= dist ~= staging (except .gitignore / .travis.yml) -0 NOTICE has wrong Copyright year +1 builds with mvn clean install -T1.0C -1 META-INF/LICENSE and META-INF/NOTICE missing from JARs (except -api and -impl) Built with: Apache Maven 3.3.9 Maven home: /usr/share/maven Java version: 1.8.0_151, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre Default locale: en_GB, platform encoding: UTF-8 OS name: "linux", version: "4.10.0-40-generic", arch: "amd64", family: "unix" On 4 December 2017 at 11:13, Sergio Fernández <wik...@apache.org> wrote: > I'd like to bring up this vote, which is waiting for votes for two weeks :-/ > > > On Nov 26, 2017 13:21, "Sergio Fernández" <wik...@apache.org> wrote: > > I'd like to ask the Commons PMC to cast a, any, vote for this RC. Because > it's stuck. It's fine to get -1s, but at least something to move forward. > Thanks. > > On Nov 22, 2017 17:52, "Sergio Fernández" <wik...@apache.org> wrote: > >> Hi Oliver, >> >> thanks for the feedback on RC2. Please, find my answers inline. >> >> On Wed, Nov 22, 2017 at 1:25 PM, Oliver Heger < >> oliver.he...@oliver-heger.de> wrote: >>> >>> [ERROR] Failed to execute goal >>> org.apache.maven.plugins:maven-site-plugin:3.6:site (default-cli) on >>> project commons-rdf-parent: Error generating >>> maven-checkstyle-plugin:2.12.1:checkstyle-aggregate: Failed during >>> checkstyle configuration: cannot initialize module TreeWalker - Property >>> 'ignoreAnnotationCanonicalNames' in module VisibilityModifier does not >>> exist, please check the documentation -> [Help 1] >>> >>> A problem with the version of the checkstyle plugin? >>> >> >> Maybe..., the version comes from Commons Parent. The issue is that I'm >> not able to reproduce the problem in Unix, neither in Linux nor OSX. >> >> Some other notes: >>> * NOTICE has the wrong copyright year. I think this needs to be fixed. >>> >> >> Yeah, I reported that as https://issues.apache.org/j >> ira/browse/COMMONSRDF-69 >> >> >>> * The project does not release binary artifacts. This is probably okay, >>> but unusual for Commons. It would be nice if you could add a binary >>> distribution - maybe for the 1.0 release. >>> >> >> Afterwards I updated the vote to include the binary release, too: >> >> https://lists.apache.org/thread.html/23cf46d92c2afa191690edc >> a5ea76c0882c108c1a9dc1709a9d9ee52@%3Cdev.commons.apache.org%3E >> >> Thanks. >> >> >> >> Am 19.11.2017 um 23:08 schrieb Sergio Fernández: >> > Hi, >> > >> > once we addressed most of the issues from RC1, I'd like to propose to >> > release Apache Commons RDF 0.5.0 based on RC2. >> > >> > Apache Commons RDF aims to provide a common Java API for RDF 1.1 graphs >> and >> > datasets. API bindings in Commons RDF 0.5.0 include Apache Jena, Eclipse >> > RDF4J, JSON-LD Java as well as a standalone implementation (simple). >> > >> > Apache Commons RDF 0.5.0 RC2 is available for review at (r23205): >> > >> > https://dist.apache.org/repos/dist/dev/commons/rdf/apache-co >> mmons-rdf-0.5.0-RC2/ >> > >> > The source code for this RC is available from git tagged as 0.5.0-RC2 >> > (commit 186df0c36981a308338792f02d93fc59776b0b7c): >> > >> > https://git-wip-us.apache.org/repos/asf?p=commons-rdf.git;a= >> commit;h=186df0c36981a308338792f02d93fc59776b0b7c >> > >> > Mirrored at >> > https://github.com/apache/commons-rdf/commit/186df0c36981a30 >> 8338792f02d93fc59776b0b7c >> > >> > This source release produces the following binary artifacts: >> > >> > commons-rdf-parent-0.5.0 >> > commons-rdf-api-0.5.0 >> > commons-rdf-simple-0.5.0 >> > commons-rdf-jena-0.5.0 >> > commons-rdf-rdf4j-0.5.0 >> > commons-rdf-jsonld-java-0.5.0 >> > commons-rdf-integration-tests-0.5.0 >> > >> > The Maven Staging repository can be found at: >> > >> > https://repository.apache.org/content/repositories/orgapachecommons-1293 >> > >> > Please vote on releasing this release candidate as: >> > >> > Apache Commons RDF 0.5.0 >> > >> > The vote is open for at least 72 hours/ >> > >> > [ ] +1 Release this package >> > [ ] 0 I don't feel strongly about it, but don't object >> > [ ] -1 Do not release this package because... >> > >> > Anyone can participate in testing and voting, not just committers, >> > please feel free to try out the release candidate and provide your >> > votes! >> > >> > Thanks >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> >> -- Stian Soiland-Reyes http://orcid.org/0000-0001-9842-9718 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org