On 1 February 2015 at 18:33, Jochen Wiedmann <jochen.wiedm...@gmail.com> wrote: > On Sun, Feb 1, 2015 at 7:04 AM, Stefan Bodewig <bode...@apache.org> wrote: > >> * (Internal)LZWInputStream has a bunch of protected fields that slipped >> through a few releases ago. We should add getter/setter pairs and >> deprecate using the fields. Sebb would like to even make the fields >> private assuming the chance of people actually subclassing >> ZCompressorInputStream and using said fields is very small. > > Make them private and be prepared to reverse the decision by pushing > out another release, if required.
I like that solution. I have created COMPRESS-300 with a suggested patch. Note that it does not use generic setters, as some of the fields were only ever set to a single value externally. > Jochen > > > > -- > Our time is just a point along a line that runs forever with no end. > (Al Stewart, Lord Grenville) > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
