On 17 December 2014 at 10:50, Luc Maisonobe <l...@spaceroots.org> wrote: > Hi Sebb, > > Le 17/12/2014 02:21, sebb a écrit : >> On 17 December 2014 at 00:01, Phil Steitz <phil.ste...@gmail.com> wrote: >>> On 12/16/14 1:51 PM, sebb wrote: >>>> On 16 December 2014 at 08:58, luc <l...@spaceroots.org> wrote: >>>>> Hi Phil, >>>>> >>>>> Le 2014-12-16 00:49, pste...@apache.org a écrit : >>>>>> Repository: commons-math >>>>>> Updated Branches: >>>>>> refs/heads/master 809f0f89c -> 540aa2e7e >>>>>> >>>>>> >>>>>> Added Bessel functions of the first kind, based on NetLib implementation. >>>>>> >>>>>> JIRA: MATH-1066 >>>>>> Based on patch provided by Brian Wignall >>>>>> >>>>>> >>>>>> Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo >>>>>> Commit: >>>>>> http://git-wip-us.apache.org/repos/asf/commons-math/commit/f80f5777 >>>>>> Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/f80f5777 >>>>>> Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/f80f5777 >>>>>> >>>>>> Branch: refs/heads/master >>>>>> Commit: f80f577748c0dbde45d24654247a82a7121d456c >>>>>> Parents: 59fe593 >>>>>> Author: Phil Steitz <phil.ste...@gmail.com> >>>>>> Authored: Mon Dec 15 13:48:07 2014 -0700 >>>>>> Committer: Phil Steitz <phil.ste...@gmail.com> >>>>>> Committed: Mon Dec 15 13:48:07 2014 -0700 >>>>>> >>>>>> ---------------------------------------------------------------------- >>>>>> findbugs-exclude-filter.xml | 7 + >>>>>> src/changes/changes.xml | 3 + >>>>>> .../apache/commons/math3/special/BesselJ.java | 649 ++++++++++++++++ >>>>>> .../commons/math3/special/BesselJTest.java | 777 >>>>>> +++++++++++++++++++ >>>>>> 4 files changed, 1436 insertions(+) >>>>>> ---------------------------------------------------------------------- >>>>> >>>>> I think the NOTICE and LICENSE file should also be updated to add the >>>>> necessary Netlib references. >>>>> This is the standard place were people can look. Currently, the credits >>>>> are >>>>> only in the BesselJ.java file, >>>>> whic seems insufficient to me. As an example for Mersenne twister I put >>>>> the >>>>> credits both in the >>>>> java source for developers and in the NOTICE and LICENSE file for global >>>>> references and end users. >>>> The NOTICE file is ONLY for REQUIRED attributions. >>>> It is vital that unnecessary content is excluded. >>> >>> Why, exactly? It is a judgement call whether or not to attribute >>> netlib here. What exactly is the harm in adding the attribution in >>> NOTICE.txt? I see the policy-by-editing-the-website stuff in the >>> link below, but personally see it as up to the RM to decide. Saying >>> in bold, "don't add anything not legally required" makes us all have >>> to be lawyers, which we are not. As a "downstream user" I like to >>> know about the third party code used to create what we are >>> distributing. >> >> AIUI the NOTICE file must be passed on to all downstream users, so it >> places an unnecessary burden on them. > > The NOTICE file is already necessary. The fact it has one line or one > hundred does not change anything on the burden for end users.
Ah, but it may if a project includes several ASF components. Each such NOTICE file will have to be examined to see if the contents need to be passed on. I did not make this rule up. As far as I know, it was established by the ASF founders, such as Roy. >> >> Remember that the LICENSE file contains - or points to - all the >> licenses, so end users have all the license info they need. >> The NOTICE file is for required attributions only. > > OK, then I will revert the last change in NOTICE (preserving the > attributions that were already there in the previous releases), and > keep the new attribution only in the LICENSE file. > >> >> I'm sure there are e-mails from Roy about and other ASF founders about >> this, but I think the link I quoted is very clear. >> >> If you want to challenge that page or ask for clarifications, please >> ask on the legal-discuss list. > > Maybe I'll do this, I'm not sure yet. > > As part of my day work, and despite I am not a lawyer, I have to help > some projects be clear about their use of open-source components. Having > a file that already includes everything without having to chase manually > thousand of source files is a *relief*, not a burden. > > best regards, > Luc > >> >>>> >>>> http://www.apache.org/dev/licensing-howto.html#mod-notice >>>> >>>> The LICENSE file must contain ALL relevant licences - or pointers to >>>> local files containing the license. >>>> >>>>> best regards, >>>>> Luc >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>>> >>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org