Le 2014-12-16 16:58, Phil Steitz a écrit :
On 12/16/14 1:58 AM, luc wrote:
Hi Phil,
Le 2014-12-16 00:49, pste...@apache.org a écrit :
Repository: commons-math
Updated Branches:
refs/heads/master 809f0f89c -> 540aa2e7e
Added Bessel functions of the first kind, based on NetLib
implementation.
JIRA: MATH-1066
Based on patch provided by Brian Wignall
Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit:
http://git-wip-us.apache.org/repos/asf/commons-math/commit/f80f5777
Tree:
http://git-wip-us.apache.org/repos/asf/commons-math/tree/f80f5777
Diff:
http://git-wip-us.apache.org/repos/asf/commons-math/diff/f80f5777
Branch: refs/heads/master
Commit: f80f577748c0dbde45d24654247a82a7121d456c
Parents: 59fe593
Author: Phil Steitz <phil.ste...@gmail.com>
Authored: Mon Dec 15 13:48:07 2014 -0700
Committer: Phil Steitz <phil.ste...@gmail.com>
Committed: Mon Dec 15 13:48:07 2014 -0700
----------------------------------------------------------------------
findbugs-exclude-filter.xml | 7 +
src/changes/changes.xml | 3 +
.../apache/commons/math3/special/BesselJ.java | 649
++++++++++++++++
.../commons/math3/special/BesselJTest.java | 777
+++++++++++++++++++
4 files changed, 1436 insertions(+)
----------------------------------------------------------------------
I think the NOTICE and LICENSE file should also be updated to add
the necessary Netlib references.
This is the standard place were people can look. Currently, the
credits are only in the BesselJ.java file,
whic seems insufficient to me. As an example for Mersenne twister
I put the credits both in the
java source for developers and in the NOTICE and LICENSE file for
global references and end users.
Good catch. Neither the source nor the readme at the next level
provide any copyright or license statement for the original Fortran;
but I agree its good to ack the source. Have a look at what I just
pushed. Hopefully OK and consistent with the other contents of
these files.
Yes, I think it is fine now.
Thanks for the quick fix.
Luc
Phil
best regards,
Luc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
