On 10 December 2014 at 09:36, Romain Manni-Bucau <rmannibu...@gmail.com> wrote: > 2014-12-10 10:07 GMT+01:00 sebb <seb...@gmail.com>: >> There are some discrepancies between the source artifact and the SVN tag. >> >> The source artifact contains derby.log under commons-jcs-jcache-openjpa >> >> The source bundles should not contain the doap file >> >> Those problems can be addressed by fixing the appropriate assembly >> descriptors. >> Note that the presence of derby.log shows how easy it is for bundles >> to contain spurious files, and why it is necessary to compare the >> source bundle with the SVN tag as part of checking the RC. >> Luckily in this case the file is harmless, but it could have been >> anything lying around in the workspace. >> >> The following directory trees are in SVN but not the source bundle: >> >> auxiliary-builds >> commons-jcs-sandbox >> src/experimental >> >> This is not a blocker, but they are a nuisance when comparing source and SVN. >> Maybe consider creating a branch and then drop them from trunk? >> >> >> The NOTICE.txt file must not contain references to LICENSE.txt >> The LICENSE.xerox file does not appear to require attribution, so the >> NOTICE.txt file must not reference Xerox. >> The LICENSE.txt file ought to contain the full text of all required >> licenses; failing that it needs to reference any external files by >> name. >> >> The source jars must have NOTICE and LICENSE files in the META-INF >> directories >> > > Which jar doesnt have it? binaries have them, didnt check > source/javadoc ones but other should have
As I wrote: it was one of the _source_ jars that did not have the files. As it happens, I checked commons-jcs-jcache-2.0-beta-1-sources The same applies to commons-jcs-jcache-extras-2.0-beta-1-sources and presumably the others. >> -1 for the N&L issues. >> >> On 5 December 2014 at 10:11, Romain Manni-Bucau <rmannibu...@gmail.com> >> wrote: >>> Hi >>> >>> Another try with license/notice files >>> >>> - here is the maven repo: >>> https://repository.apache.org/content/repositories/orgapachecommons-1065 >>> - assemblies can be found here >>> https://repository.apache.org/content/repositories/orgapachecommons-1065/org/apache/commons/commons-jcs-dist/2.0-beta-1/ >>> - tag is here: >>> http://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.0-beta-1/ >>> - KEYS: https://www.apache.org/dist/commons/KEYS >>> - Site staging is: >>> http://people.apache.org/~rmannibucau/commons-jcs-2.0-beta-1/ >>> - rat report is (not I delete LICENSE.xerox and zipcodes.txt from this >>> report directly cause I didn't find a way to configure apache-rat >>> correctly with maven site): >>> http://people.apache.org/~rmannibucau/commons-jcs-2.0-beta-1/rat-report.html >>> >>> About last vote we spoke about should assembly contain a readme, the >>> site or something like that, I checked few projects and it doesn't >>> seem mandatory so I didn't update them. >>> >>> Please review the release candidate and vote. >>> This vote will close no sooner that 72 hours from now or until we get >>> 3 PMC votes. >>> >>> [ ] +1 Release these artifacts >>> [ ] +-0 OK, but... >>> [ ] -1 I oppose this release because... >>> >>> >>> Here is my +1 >>> >>> >>> Romain Manni-Bucau >>> @rmannibucau >>> http://www.tomitribe.com >>> http://rmannibucau.wordpress.com >>> https://github.com/rmannibucau >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
