Hi.
[...]
The change i am bringing in is simple in that in any case of
either of
them nan or both then return true or false and if and only if both
are
*not nan* then get to Precision.equals
Does any on have a concern adding this method or if the change
needs
to be done else where such as in Precision.equalsIncludingNaN
What is the semantics of this new method?
Is it different from all of the following:
* MathUtils.equals
* Precision.equals
* Precision.equalsIncludingNaN
?
No. its the same as all the three methods with just 2 double
attributes and a boolean return
Or is the issue about performance?
If so the problem must be identified and the corresponding method
improved.
Yes it was performance related issue with
Precision.equalsIncludingNan
and hence will improve that method
[...]
I've attached a benchmark on the JIRA page.
It's not obvious that it's worth changing the current code (doing so
will
obviously make it less clear).
We've had this kind of argument in the past, with diverging opinions...
Regards,
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
