So what's the idea here? Should we apply additional logging layer (as Jason proposed)? Or throw it away and start thinking about new release?
I have reviewed TODOs and I haven't spotted any urgent task for now. Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ 2013/9/4 Jason Pyeron <jpye...@pdinc.us>: >> -----Original Message----- >> From: Benedikt Ritter [mailto:brit...@apache.org] >> Sent: Wednesday, September 04, 2013 4:28 >> To: Commons Developers List >> Subject: Re: [OGNL] Make use of logging? >> >> 2013/9/4 Lukasz Lenart <lukaszlen...@apache.org> >> >> > 2013/9/3 Christian Grobmeier <grobme...@gmail.com>: >> > > I found 11 uses of e.printStackTrace and think its pretty bad. >> > > Including OgnlException overwrites printStackTrace and writes to >> > > System.err for some reason. >> > > >> > > In addition there are a lot of System.out's, but those are all >> > > commented and seem to have served debugging purposes. >> > > >> > > I believe small libs like OGNL should not have logging at >> all, but >> > > it seems some of the logging here might make sense. I am >> tending to >> > > enable slf4j, which is already used in the testing scope. >> Once done >> > > we should use the logging methods for System.out and >> printStackTrace. >> > >> > Why not Log4j or commons-logging? >> > >> > And it's really annoying to have different logging libs in the same >> > project just because dependency uses that particular one - I like >> > Struts2 way where you can choose what logging library you >> want to use. >> > I don't know if developing additional thin layer is a huge >> problem - >> > we can copy paste from S2 ;-) >> > >> >> I agree that small libs should not have logging at all. Are >> you really sure it is needed (sorry don't have the time to >> dig into the code myself right know)? >> > > As someone who has had to modify the code, yes logging should exist. I have a > fork of it with util.logging here. > > > -- > -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- > - - > - Jason Pyeron PD Inc. http://www.pdinc.us - > - Principal Consultant 10 West 24th Street #100 - > - +1 (443) 269-1555 x333 Baltimore, Maryland 21218 - > - - > -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- > This message is copyright PD Inc, subject to license 20080407P00. > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
