2013/9/3 Christian Grobmeier <grobme...@gmail.com>: > I found 11 uses of e.printStackTrace and think its pretty bad. > Including OgnlException overwrites printStackTrace and writes to > System.err for some reason. > > In addition there are a lot of System.out's, but those are all commented > and seem to have served debugging purposes. > > I believe small libs like OGNL should not have logging at all, but it > seems some of the logging here might make sense. I am tending to enable > slf4j, which is already used in the testing scope. Once done we should > use the logging methods for System.out and printStackTrace.
Why not Log4j or commons-logging? And it's really annoying to have different logging libs in the same project just because dependency uses that particular one - I like Struts2 way where you can choose what logging library you want to use. I don't know if developing additional thin layer is a huge problem - we can copy paste from S2 ;-) Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
