On 30/10/2013 19:52, Benedikt Ritter wrote: > On my machine the tests take forever to run, about 5 minutes for mvn test. > I guess this is normal? (haven't looked into the tests in detail)
Yes, that is normal. A number of the tests check various timeouts (eviction, abandoned objects etc.) so they sleep while waiting for the timeouts to expire. > Test coverage in the proxy package is relatively low (58%) but since I'm > not involved in the development I don't know how easy/hard it is to improve > coverage. Not too hard. I've added a few more unit tests. > FindBugs Found reliance on default encoding in new > org.apache.commons.pool2.impl.AbandonedConfig(): new > java.io.PrintWriter(OutputStream). An exclusion with an explanatory comment > could be added for RC 2. I'd already spotted and fixed this one. > We had this discussion [1] about Configuration 1.10 regard copy rights and > naming (there was another thread about this, but I can't find it > currently). Looks like the commons Pool logo is missing a trade mark. I'm no graphics designer so I just copied the TM from the BeanUtils library. > If I > understand correctly every mentioning of "pool", and "Commons pool" has to > be changed to "the Apache Commons Pool component". The brand guidelines aren't quite that rigid but I suspect the docs are in need of a review. I've taken a first look. Some more tweaks will probably be required. I prefer s/component/library/ > The RELEASE_NOTES.txt say: > > The Apache Commons Pool team is pleased to announce the release of > commons-pool2-2.0 > > This is probably generated from maven project.name. Sounds strange to me > because the head line says "Apache Commons Pool 2.0 RELEASE NOTES" Fixed. > One minor thing: the vote mail contained a wrong URL for the tag. It said > http://svn.apache.org/repos/asf/commons/proper/foo/tags/POOL_2_0_RC1/ > where is should have been > http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_0_RC1/<http://svn.apache.org/repos/asf/commons/proper/foo/tags/POOL_2_0_RC1/> That will be because I copied and pasted the text from the step-by-step guide and forgot to fix that URL. I'll fix it for the next RC. Thanks for the feedback. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
