Hello Mark, Builds fine with:
Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 17:22:22+0200) Maven home: /Applications/dev/maven/apache-maven-3.1.1 Java version: 1.7.0_40, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_40.jdk/Contents/Home/jre Default locale: de_DE, platform encoding: UTF-8 OS name: "mac os x", version: "10.9", arch: "x86_64", family: "mac" Side looks good, signs are good, archives and tag have the same content On my machine the tests take forever to run, about 5 minutes for mvn test. I guess this is normal? (haven't looked into the tests in detail) Test coverage in the proxy package is relatively low (58%) but since I'm not involved in the development I don't know how easy/hard it is to improve coverage. FindBugs Found reliance on default encoding in new org.apache.commons.pool2.impl.AbandonedConfig(): new java.io.PrintWriter(OutputStream). An exclusion with an explanatory comment could be added for RC 2. We had this discussion [1] about Configuration 1.10 regard copy rights and naming (there was another thread about this, but I can't find it currently). Looks like the commons Pool logo is missing a trade mark. If I understand correctly every mentioning of "pool", and "Commons pool" has to be changed to "the Apache Commons Pool component". The RELEASE_NOTES.txt say: The Apache Commons Pool team is pleased to announce the release of commons-pool2-2.0 This is probably generated from maven project.name. Sounds strange to me because the head line says "Apache Commons Pool 2.0 RELEASE NOTES" One minor thing: the vote mail contained a wrong URL for the tag. It said http://svn.apache.org/repos/asf/commons/proper/foo/tags/POOL_2_0_RC1/ where is should have been http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_0_RC1/<http://svn.apache.org/repos/asf/commons/proper/foo/tags/POOL_2_0_RC1/> Thanks, Benedikt [1] http://markmail.org/thread/bmyypnqnkfcg3wgp 2013/10/30 Mark Thomas <ma...@apache.org> > On 30/10/2013 17:52, Mark Thomas wrote: > > <snip/> > > > Please review the release candidate and vote. > > This vote will close no sooner that 72 hours from now > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [X] -1 I oppose this release because... > > I've just changed the API to break a cyclic dependency. There is > definitely going to need to be another RC. I'll leave this vote open for > now to give folks a chance to find any other issues. > > Mark > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
