Hi James, Send from my mobile device
> Am 05.10.2013 um 00:33 schrieb James Carman <ja...@carmanconsulting.com>: > > Also, since when did we start nit-picking code in the sandbox? Why > not leave these folks alone and let them work out their ideas? The > sandbox should be an area where folks can play around with stuff and > share new ideas without being hassled by folks. If we make it a pain > in the butt, then people will just go elsewhere with their cool ideas. > It's one thing if you're collaborating on the project, but trolling > commit logs and picking out things you don't like is just plain rude, > IMHO. I'm not sure I agree with all of your points. Yes, the sandbox is a place to try new ideas out. Does this mean certain quality criterions do not apply? I don't think so. This all has to be corrected before promotion, so why not make it correct right from the start? Is pointing out that something may be improved nit-picking? Well, I think it depends :-) Just sending a -1 for a commit like this would definitely be. In this case an improvement has been pointed out. I'm more then happy for feedback like this, because it helps me become a better developer. And in the end, discussing commits is part of the game ;-) Regards, Benedikt > >> On Fri, Oct 4, 2013 at 6:23 PM, James Carman <ja...@carmanconsulting.com> >> wrote: >>> On Fri, Oct 4, 2013 at 6:11 PM, sebb <seb...@gmail.com> wrote: >>> >>> Back to the case in point: why is the string ".activate" and not anything >>> else? >> >> Why not just extract a constant and name it something logical like >> "ACTIVATED_INDICATOR"? Then, the actual value of the constant can be >> whatever you want. The value of the string isn't important (other >> than making it a bit more human-readable of course). What is >> important is that you use the string in a consistent fashion >> throughout your code. By not using a constant, it makes it more >> likely to fat-finger the value when you type it again somewhere. >> Anyway, I'm sure I'm not telling you anything new. I just don't think >> it's relevant to go into a lengthy discussion about the string that's >> used as some sort of marker. Just extract the constant (and use it) >> and move on. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
