On 4 October 2013 23:23, James Carman <ja...@carmanconsulting.com> wrote: > On Fri, Oct 4, 2013 at 6:11 PM, sebb <seb...@gmail.com> wrote: >> >> Back to the case in point: why is the string ".activate" and not anything >> else? >> > > Why not just extract a constant and name it something logical like > "ACTIVATED_INDICATOR"? Then, the actual value of the constant can be > whatever you want. The value of the string isn't important (other > than making it a bit more human-readable of course). What is > important is that you use the string in a consistent fashion > throughout your code. By not using a constant, it makes it more > likely to fat-finger the value when you type it again somewhere. > Anyway, I'm sure I'm not telling you anything new. I just don't think > it's relevant to go into a lengthy discussion about the string that's > used as some sort of marker. Just extract the constant (and use it) > and move on.
That was exactly my point. However, I don't think the value is arbitrary, given that it is only used once. It looks to me as though the code is relying on some external convention for property naming. > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
