On 2 October 2013 21:12,  <jlmonte...@apache.org> wrote:
> Author: jlmonteiro
> Date: Wed Oct  2 20:12:29 2013
> New Revision: 1528612
>
> URL: http://svn.apache.org/r1528612
> Log:
> Fixing configuration property typo
>
> Modified:
>     
> commons/sandbox/monitoring/trunk/reporting/src/main/java/org/apache/commons/monitoring/reporting/web/plugin/PluginRepository.java
>
> Modified: 
> commons/sandbox/monitoring/trunk/reporting/src/main/java/org/apache/commons/monitoring/reporting/web/plugin/PluginRepository.java
> URL: 
> http://svn.apache.org/viewvc/commons/sandbox/monitoring/trunk/reporting/src/main/java/org/apache/commons/monitoring/reporting/web/plugin/PluginRepository.java?rev=1528612&r1=1528611&r2=1528612&view=diff
> ==============================================================================
> --- 
> commons/sandbox/monitoring/trunk/reporting/src/main/java/org/apache/commons/monitoring/reporting/web/plugin/PluginRepository.java
>  (original)
> +++ 
> commons/sandbox/monitoring/trunk/reporting/src/main/java/org/apache/commons/monitoring/reporting/web/plugin/PluginRepository.java
>  Wed Oct  2 20:12:29 2013
> @@ -35,7 +35,7 @@ public final class PluginRepository {
>              if (name == null) {
>                  throw new IllegalArgumentException("plugin name can't be 
> null");
>              }
> -            if (!Configuration.is(name + "activated", true)) {
> +            if (!Configuration.is(name + ".activated", true)) {

I assume that this string is used elsewhere within monitoring?
If so, it should be defined once as a String constant (with Javadoc)
and used throughout.
Or there could be a method to convert a name by appending the suffix.

>                  continue;
>              }
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to