+1 too Oliver, great work! -Simo
http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Tue, Jan 31, 2012 at 11:05 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > On Tue, Jan 31, 2012 at 4:08 PM, Oliver Heger > <oliver.he...@oliver-heger.de>wrote: > >> Hi Gary, >> >> Am 30.01.2012 22:37, schrieb Gary Gregory: >> >> Hi Oliver: >>> >>> These header issues are not real blockers (hence my -0). I was hoping to >>> nudge you into fixing these but I also know that cutting another RC can be >>> a pain. >>> >>> My POV is that consistency is important. Why make people spend time >>> figuring out if RAT warnings are valid or not, especially when the fix is >>> trivial? With 0 RAT warnings, I can move on to the next item down the >>> check >>> list. >>> >>> I would be happy if these header issues were all fixed in trunk such that >>> the next release would pick them up. I do not think that "it was already >>> broken" is a good reason to skip a task ;) >>> >>> Then I could +1 this release with the comfort that the next release would >>> have the 'fixes'. >>> >>> Gary >>> >> >> point taken, and it turned out that it was really good to look at these >> issues: >> - The css file was obviously not needed, maybe it was a relict from the >> maven 1 build. I removed it. >> - A license header was added to PROPOSAL.html. >> - I am afraid, I currently cannot solve the issue with the plist file. The >> parser for plist files in [configuration] cannot deal with comments. I >> created [CONFIGURATION-477] for this purpose (to be fixed in a later >> release). So this is the only file the RAT report complains about. >> > > Very nice! Thank you. Voila: +1. > > Gary > > >> Oliver >> >> >>> On Mon, Jan 30, 2012 at 3:36 PM, Oliver Heger >>> <oliver.he...@oliver-heger.de>**wrote: >>> >>> Hi Simone and Gary, >>>> >>>> thanks for reviewing. >>>> >>>> Regarding the missing license headers: >>>> - project.css is a trivial one-liner, AIUI it is not required to have a >>>> header in such cases. >>>> - test.plist is a test configuration file used by some unit tests. I >>>> would >>>> add a header, but I don't know what would be the correct format for plist >>>> files. OTOH, I assume that simple test files can also go without headers >>>> as >>>> they really do not contain any intellectual properties. >>>> - PROPOSAL.html is around since the very beginning and never had a >>>> header. >>>> >>>> Please take into account that the affected files have not been changed >>>> since the last release. >>>> >>>> Regarding dependencies to other commons components: >>>> I think we updated all dependencies possible without breaking binary >>>> compatibility (for instance, the public API exposes some classes of >>>> Commons >>>> Lang, therefore we could not update to Lang 3.0). An exception is the >>>> dependency to Digester, but this is used by a single class only which is >>>> deprecated. So there is no big motivation to change something in this >>>> area. >>>> >>>> Could I convince you to a +1 vote ;-) >>>> Oliver >>>> >>>> Am 30.01.2012 19:03, schrieb Gary Gregory: >>>> >>>> -0 >>>>> >>>>> Looks like a couple of missing headers. >>>>> >>>>> For me, I see: >>>>> >>>>> Unapproved licenses: >>>>> >>>>> src/site/xdoc/style/project.****css >>>>> >>>>> src/test/resources/test.plist >>>>> >>>>> >>>>> I see no complaint about PROPOSAL.html which IS missing a header. >>>>> >>>>> Now that the component requires Java 5, it seems like a good time to >>>>> update >>>>> the deps too, not critical for 1.8, but should be considered if another >>>>> RC >>>>> is made. >>>>> >>>>> Tested with: >>>>> >>>>> Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) >>>>> Maven home: C:\Java\apache-maven-3.0.4\****bin\.. >>>>> >>>>> Java version: 1.6.0_29, vendor: Sun Microsystems Inc. >>>>> Java home: C:\Program Files\Java\jdk1.6.0_29\jre >>>>> Default locale: en_US, platform encoding: Cp1252 >>>>> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" >>>>> >>>>> Gary >>>>> >>>>> On Mon, Jan 30, 2012 at 11:46 AM, Simone Tripodi >>>>> <simonetrip...@apache.org>****wrote: >>>>> >>>>> Hello Oliver, >>>>> >>>>>> >>>>>> I am for getting [configuration] released >>>>>> >>>>>> * binaries checksums+gpg are OK >>>>>> * clirr report is OK >>>>>> * checkstyle is OK >>>>>> * findbugs is OK >>>>>> * project build OK >>>>>> * mvn artifacts look having right metadata (Implementation-Build) >>>>>> >>>>>> there is the RAT report that shows that there are 3 Unknown Licenses - >>>>>> not sure this is blocking >>>>>> >>>>>> Unapproved licenses: >>>>>> PROPOSAL.html >>>>>> src/site/xdoc/style/project.****css >>>>>> >>>>>> src/test/resources/test.plist >>>>>> >>>>>> Can you provide a feedback please? Many thanks in advance, all the >>>>>> best! >>>>>> -Simo >>>>>> >>>>>> http://people.apache.org/~****simonetripodi/<http://people.apache.org/%7E**simonetripodi/> >>>>>> <http://people.**apache.org/%7Esimonetripodi/<http://people.apache.org/%7Esimonetripodi/> >>>>>> > >>>>>> http://simonetripodi.**livejou**rnal.com/ <http://livejournal.com/>< >>>>>> http://**simonetripodi.livejournal.com/<http://simonetripodi.livejournal.com/> >>>>>> **> >>>>>> http://twitter.com/****simonetripodi<http://twitter.com/**simonetripodi> >>>>>> <http://twitter.**com/simonetripodi <http://twitter.com/simonetripodi> >>>>>> > >>>>>> >>>>>> http://www.99soft.org/ >>>>>> >>>>>> >>>>>> >>>>>> On Fri, Jan 27, 2012 at 10:19 PM, Oliver Heger >>>>>> <oliver.he...@oliver-heger.de> wrote: >>>>>> >>>>>> Hi all, >>>>>>> >>>>>>> this is a vote for releasing Commons Configuration 1.8 based on the >>>>>>> first >>>>>>> release candidate. Configuration has been updated to support new >>>>>>> language >>>>>>> features of Java 1.5 (which is now the minimum required JDK version). >>>>>>> >>>>>>> This >>>>>> >>>>>> could be achieved in a binary compatible way. >>>>>>> >>>>>>> Tag: >>>>>>> >>>>>>> https://svn.apache.org/repos/****asf/commons/proper/**<https://svn.apache.org/repos/**asf/commons/proper/**> >>>>>>> >>>>>> configuration/tags/****CONFIGURATION_1_8RC1<https://** >>>>>> svn.apache.org/repos/asf/**commons/proper/configuration/** >>>>>> tags/CONFIGURATION_1_8RC1<https://svn.apache.org/repos/asf/commons/proper/configuration/tags/CONFIGURATION_1_8RC1> >>>>>> > >>>>>> >>>>>> >>>>>>> Binaries: >>>>>>> http://people.apache.org/~****oheger/configuration-1.8rc1/<http://people.apache.org/%7E**oheger/configuration-1.8rc1/> >>>>>>> <h**ttp://people.apache.org/%**7Eoheger/configuration-1.8rc1/<http://people.apache.org/%7Eoheger/configuration-1.8rc1/> >>>>>>> **> >>>>>>> >>>>>>> Maven artifacts: >>>>>>> http://people.apache.org/~****oheger/configuration-1.8rc1/****maven/<http://people.apache.org/%7E**oheger/configuration-1.8rc1/**maven/> >>>>>>> <http://people.apache.**org/%7Eoheger/configuration-1.**8rc1/maven/<http://people.apache.org/%7Eoheger/configuration-1.8rc1/maven/> >>>>>>> > >>>>>>> >>>>>>> Site: >>>>>>> http://people.apache.org/~****oheger/configuration-1.8rc1/****site/<http://people.apache.org/%7E**oheger/configuration-1.8rc1/**site/> >>>>>>> <http://people.apache.**org/%7Eoheger/configuration-1.**8rc1/site/<http://people.apache.org/%7Eoheger/configuration-1.8rc1/site/> >>>>>>> > >>>>>>> >>>>>>> Release notes: >>>>>>> http://people.apache.org/~****oheger/configuration-1.8rc1/**<http://people.apache.org/%7E**oheger/configuration-1.8rc1/**> >>>>>>> RELEASE-NOTES.txt<http://**people.apache.org/%7Eoheger/** >>>>>>> configuration-1.8rc1/RELEASE-**NOTES.txt<http://people.apache.org/%7Eoheger/configuration-1.8rc1/RELEASE-NOTES.txt> >>>>>>> > >>>>>>> >>>>>>> >>>>>>> [ ] +1 Release these artifacts >>>>>>> [ ] +0 OK, but... >>>>>>> [ ] -0 OK, but really should fix... >>>>>>> [ ] -1 I oppose this release because... >>>>>>> >>>>>>> Vote will remain open for 72 hours. >>>>>>> >>>>>>> Thanks! >>>>>>> Oliver >>>>>>> >>>>>>> ------------------------------****----------------------------**--** >>>>>>> --------- >>>>>>> To unsubscribe, e-mail: >>>>>>> dev-unsubscribe@commons.**apac**he.org<http://apache.org> >>>>>>> <dev-unsubscribe@**commons.apache.org<dev-unsubscr...@commons.apache.org> >>>>>>> > >>>>>>> >>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>>> >>>>>>> >>>>>>> ------------------------------****----------------------------**--** >>>>>> --------- >>>>>> To unsubscribe, e-mail: >>>>>> dev-unsubscribe@commons.**apac**he.org<http://apache.org> >>>>>> <dev-unsubscribe@**commons.apache.org<dev-unsubscr...@commons.apache.org> >>>>>> > >>>>>> >>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>> ------------------------------****----------------------------** >>>> --**--------- >>>> To unsubscribe, e-mail: >>>> dev-unsubscribe@commons.**apac**he.org<http://apache.org> >>>> <dev-unsubscribe@**commons.apache.org<dev-unsubscr...@commons.apache.org> >>>> > >>>> >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>>> >>>> >>> >>> >> >> ------------------------------**------------------------------**--------- >> To unsubscribe, e-mail: >> dev-unsubscribe@commons.**apache.org<dev-unsubscr...@commons.apache.org> >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
