On Wed, May 4, 2011 at 10:21 AM, Matt Benson <gudnabr...@gmail.com> wrote:
> On Wed, May 4, 2011 at 8:14 AM, Gary Gregory <garydgreg...@gmail.com> > wrote: > > On May 4, 2011, at 8:36, Matt Benson <gudnabr...@gmail.com> wrote: > > > >> On Wed, May 4, 2011 at 5:39 AM, Stephen Colebourne < > scolebou...@joda.org> wrote: > >>> (review now back from holiday) > >>> > >>> -1 > >> [SNIP] > >>> I'm still looking for ImmutablePair to be final too, but perhaps I > >>> missed the conclusion of that debate... (NOT DONE in SVN) > >>> > >> > >> Gary, now that you have toString(format) back, can you function with > this? > > > > Yes. I do not need that class to be Formattable. > > The question was whether you need it to be extensible. ;) > Ah, well, it would make it easier to port my current code: create subclasses with the desired formatting and replace package names. Each subclass would call toString(format) and that's it. The alternative is to either call toString(format) from the call sites (sure, I could refactor that in a Utils class) or have my factory classes create pair wrappers. But it seems easier to keep reusing the current code than creating wrappers. If the class is final, I have to go the Utils route, I do not have the choice. I just do not see the point of hand-cuffing users by making the class final. I can always find new ways of shooting myself in the foot... ;) Gary > Matt > > > > > Gary > > > >> > >> Matt > >> > >>> I also made some minor javadoc changes. > >>> > >>> Stephen > >>> > >>> > >>> > >>> On 29 April 2011 07:47, Henri Yandell <flame...@gmail.com> wrote: > >>>> Lang is ready to consider 3.0 release again. > >>>> > >>>> RC3 is available here: > >>>> > >>>> http://people.apache.org/~bayard/commons-lang3-3.0-RC3/ > >>>> > >>>> Maven artifacts: > >>>> > >>>> http://people.apache.org/~bayard/commons-lang3-3.0-RC3/maven/ > >>>> > >>>> Website: > >>>> > >>>> http://people.apache.org/~bayard/commons-lang3-3.0-RC3/site/ > >>>> > >>>> Note that there is a 2.6->3.0 Clirr report in the site that may prove > useful: > >>>> > >>>> > http://people.apache.org/~bayard/commons-lang3-3.0-RC3/site/lang2-lang3-clirr--report.html > >>>> > >>>> This vote will close no sooner than in 72 hours time, 0700 GMT 2-May > 2011. > >>>> > >>>> ================ > >>>> [ ] +1 > >>>> [ ] -1, with reason > >>>> ================ > >>>> > >>>> Hen > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >>>> For additional commands, e-mail: dev-h...@commons.apache.org > >>>> > >>>> > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >>> For additional commands, e-mail: dev-h...@commons.apache.org > >>> > >>> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- Thank you, Gary http://garygregory.wordpress.com/ http://garygregory.com/ http://people.apache.org/~ggregory/ http://twitter.com/GaryGregory
