On 4 May 2011 12:11, sebb <seb...@gmail.com> wrote: > On 29 April 2011 07:47, Henri Yandell <flame...@gmail.com> wrote: >> Lang is ready to consider 3.0 release again. >> >> RC3 is available here: >> >> http://people.apache.org/~bayard/commons-lang3-3.0-RC3/ >> >> Maven artifacts: >> >> http://people.apache.org/~bayard/commons-lang3-3.0-RC3/maven/ >> >> Website: >> >> http://people.apache.org/~bayard/commons-lang3-3.0-RC3/site/ >> >> Note that there is a 2.6->3.0 Clirr report in the site that may prove useful: >> >> http://people.apache.org/~bayard/commons-lang3-3.0-RC3/site/lang2-lang3-clirr--report.html >> >> This vote will close no sooner than in 72 hours time, 0700 GMT 2-May 2011. > > -1. > > I think the method (new to 3.0) > > FormatCache.getDateTimeInstance(Integer dateStyle, Integer timeStyle, > TimeZone timeZone, Locale locale) > > should be changed to use ints, as all the existing callers use ints. > > Furthermore, the parameters have to be unboxed in order to pass them > to DateFormat, so the boxing/unboxing is unnecessary and wasteful. >
Also, I'm not entirely happy with the boxing that is often needed to create a Range of int or long, e.g. in StringEscapeUtils. Seems to me these are special cases that should be handled within Range - or perhaps by special classes that could be more efficient by avoiding the boxing and unboxing altogether. >> >> ================ >> [ ] +1 >> [ ] -1, with reason >> ================ >> >> Hen >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
