On Thu, Mar 3, 2011 at 5:59 AM, Stephen Colebourne <scolebou...@joda.org> wrote: > I'm not overly enthused about some of the changes, but since I've not > been paying attention its difficult for me to vote/block. Anyway here > is my review: > [SNIP] > I don't love the new Pair class. We have an interface based version > here at OpenGamma to allow primitive implementations for performance. > I might be able to get our code released if there was interest.
Providing interfaces without code that consumes them doesn't feel like [lang]'s mission; this is akin to providing exceptions we don't use IMHO. It might be okay for Pair<L, R> to implement Map.Entry<L, R>, for example. But when you say primitive implementations, do you mean implementations based around primitive types, or simplistic implementations? If the latter, how much more simplistic could it get? Beyond this it would seem many of the points you raise are documentation-related, which wouldn't seem to preclude a beta release. Matt [SNIP] --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
