On Sat, Mar 5, 2011 at 8:46 AM, Oliver Heger <oliver.he...@oliver-heger.de> wrote: > Two minor points from my side: > > - There are still many checkstyle errors in the current code base.
Can be improved but nothing felt hugely critical. A large amount are lines greater than 120 chars. Looks like SystemUtils has been formatted for 135 chars and creates a lot of the warnings. A fair number of generic parameter javadoc items. Nothing I'd want to hold a release up for; but anyone can jump in and improve. I've added javadoc for StringEscapeUtils and EntityArray as they felt like large ones. > - Just a proposal: There are some translators in the new translate package > which can be configured with a range of the codes to be processed. Would it > make sense to use the Range class for this purpose? Then configuration could > be more flexible (because multiple ranges could be specified), and there > would probably be less duplicate code for checking the ranges. Very interesting. Also makes me wonder if Range should support the notion of Range.above, Range.below and Range.outside in addition to Range.between and Range.is. That change the API from: UnicodeEscaper.between(x, y) to: new UnicodeEscaper(Range.between(x,y)) new UnicodeEscaper(Range.above(y)) new UnicodeEscaper(Range.below(x)) new UnicodeEscaper(Range.outsideOf(x,y)) For the translators; sounds great. I'm trying to remember if I hit problems introducing the feature of either an open-ended Range, or an inverted Range. Looking at LANG-551, it looks like I tried to introduce the inverted Range notion (outsideOf) so that I could merge in CharRange, and it never really worked. Worth trying again I think. Hen --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
