This distributiion has not been built from whats been tagged as
NET_1_5_0 in subversion - the pom.xml and issue-tracking.xml files are
different. Also the source distro contains files which are not in the
subversion repo (TFTPClient-1.4.1-fix.diff, TFTPClient.java.orig and
TFTPClient.java.rej) and a couple of files (TFTPServerPathTests.java,
and TFTPTests.java) are missing the standard source file headers
(according to the RAT report)
   http://people.apache.org/~rwinston/commons-net-1.5.0/site/rat-report.html

So -1 from me and please do a clean checkout from the tagged copy when
building any release candidates.

Few of other points:
1) The binary assembly descriptor for Net 1.x includes the javadocs in
the binary distro - but the "site" needs to be generated before the
assembly target is run, otherwise they are missing - as in they are in
this RC.
2) If you use the "rc" profile, commons-parent automatically generates
-sources.jar and -javadoc.jar which are nice to have
3) There are no tar.gz source/binary distros which the Net 1.x
source/binary assembly descriptors produce

Running the following maven command when building resolves the above:
   mvn -Prc site assembly:assembly

4) Would be nice to have release notes
5) I prefer to vote on the actual aritfacts that are being
distributed, rather than SNAPSHOT versions - so the best you'll get
from me is a +0 when releasing this way
6) Would be nice to see clirr reports to see if there are any
incompatibilities with previous releases.

Niall


On Sun, Mar 2, 2008 at 11:31 PM, Rory Winston <[EMAIL PROTECTED]> wrote:
>
> Hi
>
>  This is a release vote for Commons Net 1.5. This release fixes a few
>  issues with TFTP errors, threading hangs, and a leap year date parsing bug.
>
>  The RC deployment is here:
>  http://people.apache.org/~rwinston/commons-net-1.5.0/site/
>
>  Binaries:
>
>  
> http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-bin.zip
>
>  Source:
>
>  
> http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-src.tar.gz
>
>  Javadocs:
>
>  http://people.apache.org/~rwinston/commons-net-1.5.0/site/apidocs/index.html
>
>  SVN tag:
>
>  http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
>
>  Here's my +1 in advance.
>  Cheers
>  Rory
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: [EMAIL PROTECTED]
>  For additional commands, e-mail: [EMAIL PROTECTED]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to