On 18/01/2008, Jochen Wiedmann <[EMAIL PROTECTED]> wrote: > Hi, > > I have prepared a release candidate 4 of commons-fileupload > 1.2.1. The SVN tag is commons-fileupload-1.2.1rc4. A list of > changes since rc3 and things that I haven't changes, > can be found below. > > As usual, the proposed distributables can be found on > > http://people.apache.org/~jochen/commons-fileupload/dist >
Contents of archives look OK, and digests are OK. > The proposed site (unchanged since rc3) is on > > http://people.apache.org/~jochen/commons-fileupload/site > > > Thanks, > > Jochen > > > [ ] +1 > [ ] =0 > [ ] -1 > > > Changes since 1.2.1rc3: > > - Upgraded commons-parent to version 7. This means, in particular, > that the maven-remote-resources-plugin is no longer used. > - MD5 and SHA1 checksums now have the binary flag (*) > - Fixed the copyright in the Javadoc bottom > - Building with Ant and Java 1.3.1 works again. > > Other comments: > > > What does "(optional)" mean in the Dependencies section under Commons IO? > > It means optional. Commons-IO is required only, if you intend to use > the DiskFileItem. > For the next release, perhaps consider linking to where this is described? > > > What commands are needed to build and test the code? > > The same than for most other commons projects: > > ant ant creates the jar, but the LICENSE is missing but otherwise it seems to work compile and test OK. > maven build Goal does not exist: commons-fileupload-1.2.1-src>maven build __ __ | \/ |__ _Apache__ ___ | |\/| / _` \ V / -_) ' \ ~ intelligent projects ~ |_| |_\__,_|\_/\___|_||_| v. 1.1 DEPRECATED: the default goal should be specified in the <build> section of project.xml instead of maven.xml ------------------------------------------------------------------------------- >> Goal 'build' does not exist in this project. "dist:build" does exist, but fails with: ------------------------------------------------------- >> Unable to obtain goal [dist:prepare-bin-filesystem] >> Unions are only allowed over node-sets ------------------------------------------------------- BUILD FAILED > mvn install Seems to work OK. > Choose what you prefer. > > > I could not find the information on the site. > > May be. However, if that is the case, then it was the same for at > least the previous two releases and it wasn't a blocking issue at the > time. Agreed, it's not blocking for the release, but it is blocking for (some) people wanting to test the release... I think the build instructions should be included in a file (e.g. README) in the source archives; it would not harm to include the information on the site as well, e.g. as done by http://commons.apache.org/io/building.html http://commons.apache.org/lang/building.html > > Also, build.xml seems to be out of date, as it refers to junit 3.8.1. > > I don't think this is a problem. > It's not a blocker, but should be upgraded for the next release along with project.xml which also refers to 3.8.1, whereas pom.xml is 3.8.2 > > -- > Look, that's why there's rules, understand? So that you think before > you break 'em. > > -- (Terry Pratchett, Thief of Time) > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
