On Dec 9, 2007 4:46 PM, Mark Thomas <[EMAIL PROTECTED]> wrote: > Mark Thomas wrote: > > Phil Steitz wrote: > >> On Dec 2, 2007 11:09 AM, Mark Thomas <[EMAIL PROTECTED]> wrote: > >>> Hi, > >>> > >>> Tomcat has been bitten [1] by a bug [2] in pool-1.3. Currently we are > >>> considering reverting to pool-1.2 but would obviously prefer to move to > >>> pool-1.4 (that included a fix for [2]) due to the many fixes in 1.3. > >>> > >>> A quick scan of the archives suggests that an offer of an extra pair of > >>> hands might help speed up a pool-1.4 release in the near term. So, here I > >>> am. > >> Thanks! This is exactly what is needed. > > > > OK. I have trunk checked out and building. I'll starting looking at > > POOL-86, POOL-97, POOL-93 & POOL-108 in terms of reviewing what is there > > and developing patches where there are gaps. I'll need to get my head > > around the pool code so I might be quiet for a couple of days. > > > > I'll add JIRA comments when I have something useful to say. > > I have taken a look at each of the issues above. Comments added to JIRA. In > summary:
Thanks! > POOL-86 - The patch in JIRA looks good to me To be clear, are you referring to the patch that was applied in rr582538. - i.e., the code in trunk? (thanks, btw, for completing some cleanup missed there :) > POOL-93 - Proposed improved patch based on patches in JIRA Committed. > POOL-97 - Proposed alternative patch that fixes 97 without a regression Committed. > POOL-108 - Proposed improved patch (see POOL-93) based on patch in JIRA > > I'm happy to re-work any/all of the patches if required. Only rework required will be if we decide to roll back or modify the POOL-86 change. Thanks again for your help on this. Phil --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
