On Nov 17, 2007 9:39 PM, Rahul Akolkar <[EMAIL PROTECTED]> wrote: > On 11/17/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > Author: niallp > > Date: Sat Nov 17 11:09:28 2007 > > New Revision: 595987 > > > > URL: http://svn.apache.org/viewvc?rev=595987&view=rev > > Log: > > Add in Checkstyle, Cobertura (can't see JCoverage m2 plugin) and PMD reports > > > <snip/> > > A while ago, you pointed out the GPL aspect [1] of Cobertura reports. > Along those lines, this may not be a good idea. > > Same comment also applies to ++revision.
They're not being included in the distros currently and there doesn't seem to be a JCoverage m2 plugin. I think the point is to get a proper opinion on 1) Is it OK to distribute those as part of the docs and 2) If it is, does it need something in the NOTICE file if they're included in the distro? I guess no-one ever followed that up at Shale? Niall > -Rahul > > [1] > http://www.nabble.com/Re%3A--VOTE--Release-Shale-version-1.0.4-p8164283.html > > > > > Modified: > > commons/proper/jexl/trunk/pom.xml > > > > Modified: commons/proper/jexl/trunk/pom.xml > > URL: > > http://svn.apache.org/viewvc/commons/proper/jexl/trunk/pom.xml?rev=595987&r1=595986&r2=595987&view=diff > > ============================================================================== > > --- commons/proper/jexl/trunk/pom.xml (original) > > +++ commons/proper/jexl/trunk/pom.xml Sat Nov 17 11:09:28 2007 > > @@ -155,17 +155,40 @@ > > </reportSet> > > </reportSets> > > </plugin> > > - <!-- > > <plugin> > > <groupId>org.apache.maven.plugins</groupId> > > <artifactId>maven-checkstyle-plugin</artifactId> > > <configuration> > > <configLocation>src/conf/checkstyle.xml</configLocation> > > + <excludes>org/apache/commons/jexl/parser/*.java</excludes> > > + <headerFile>src/conf/header.txt</headerFile> > > <enableRulesSummary>false</enableRulesSummary> > > - > > <propertyExpansion>checkstyle.header.file=src/conf/header.txt</propertyExpansion> > > </configuration> > > </plugin> > > - --> > > + <plugin> > > + <groupId>org.codehaus.mojo</groupId> > > + <artifactId>cobertura-maven-plugin</artifactId> > > + <version>2.1</version> > > + </plugin> > > + <plugin> > > + <groupId>org.apache.maven.plugins</groupId> > > + <artifactId>maven-pmd-plugin</artifactId> > > + <version>2.2</version> > > + <configuration> > > + <excludes> > > + <exclude>org/apache/commons/jexl/parser/*.java</exclude> > > + </excludes> > > + <rulesets> > > + <ruleset>/rulesets/braces.xml</ruleset> > > + <ruleset>/rulesets/unusedcode.xml</ruleset> > > + <ruleset>/rulesets/imports.xml</ruleset> > > + <ruleset>/rulesets/codesize.xml</ruleset> > > + <ruleset>/rulesets/coupling.xml</ruleset> > > + <ruleset>/rulesets/design.xml</ruleset> > > + <ruleset>/rulesets/strings.xml</ruleset> > > + </rulesets> > > + </configuration> > > + </plugin> > > </plugins> > > </reporting> > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
