Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1403#discussion_r59085891
  
    --- Diff: 
engine/storage/volume/src/org/apache/cloudstack/storage/datastore/PrimaryDataStoreImpl.java
 ---
    @@ -239,10 +241,34 @@ public boolean isManaged() {
             return pdsv.isManaged();
         }
     
    +    private boolean canCloneVolume() {
    +        return new 
Boolean(getDriver().getCapabilities().get(DataStoreCapabilities.CAN_CREATE_VOLUME_FROM_VOLUME.toString()));
    --- End diff --
    
    ``new Boolean`` skips the constant pool -- placing unnecessary pressure on 
the garbage collector.  Please use ``Boolean.valueOf`` instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to