Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59083203
--- Diff:
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/FakePrimaryDataStoreDriver.java
---
@@ -90,7 +96,7 @@ public void makeTakeSnapshotSucceed(boolean success) {
}
@Override
- public void revertSnapshot(SnapshotInfo snapshot,
AsyncCompletionCallback<CommandResult> callback) {
+ public void revertSnapshot(SnapshotInfo snapshotOnImageStore,
SnapshotInfo snapshotOnPrimaryStore, AsyncCompletionCallback<CommandResult>
callback) {
--- End diff --
This appears to be the default implementation from the IDE. I realize that
it predates this patch, but should method do more? If not, can we strike the
IDE generated comment to avoid future confusion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
