Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59083160
--- Diff:
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/FakePrimaryDataStoreDriver.java
---
@@ -65,8 +66,13 @@ public long getUsedIops(StoragePool storagePool) {
}
@Override
- public long getVolumeSizeIncludingHypervisorSnapshotReserve(Volume
volume, StoragePool pool) {
- return volume.getSize();
+ public long
getDataObjectSizeIncludingHypervisorSnapshotReserve(DataObject dataObject,
StoragePool pool) {
+ return dataObject.getSize();
+ }
+
+ @Override
+ public long getBytesRequiredForTemplate(TemplateInfo templateInfo,
StoragePool storagePool) {
+ return 0;
--- End diff --
Minor Nit: ``0`` is an integer value. ``0L`` is a long value. Java
automatically widens the value, but it is more hygienic to match the type for a
constant value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
