Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r51362827
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -4251,6 +4257,34 @@ public void rebootVM(final Connection conn, final VM
vm, final String vmName) th
}
}
+ protected String skipOrRemoveSR(Connection conn, SR sr) {
--- End diff --
@anshul1886 @DaanHoogland @rodrigo93 As an ideia. Maybe it could have a
name like "removeSrIfNotNull" or "removeSrIfVdiOperationAndSrNotNull".
As an example, a documetation could look like:
`/** Removes the SR if the SR is not null and exists a VDI operation for
this SR*/`
Do you think that one of this options (or anoter in your mind) could
improve this code? :-)
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
