Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r51362146
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -4251,6 +4257,34 @@ public void rebootVM(final Connection conn, final VM
vm, final String vmName) th
}
}
+ protected String skipOrRemoveSR(Connection conn, SR sr) {
--- End diff --
NP @GabrielBrascher My point is not with the protection level but with
comment being a last resort that should only decided upon to add if all else
fails. Thought last resort is further away the higher the protection level.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
