Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r51361803
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -4251,6 +4257,34 @@ public void rebootVM(final Connection conn, final VM
vm, final String vmName) th
}
}
+ protected String skipOrRemoveSR(Connection conn, SR sr) {
--- End diff --
@GabrielBrascher Pointing to oracle is not a good support for your point.
You give a good example of why a well named method should still be
documented. It's name does not make clear how it works. This should be
addressed in a different way in my opinion: Can this be renamed to better
depict what it does and only if all else fails should the user have to RTFM.
@rodrigo93 starts with asking for javadoc. Such questions have been asked a lot
lately and mostly unjust (not just by @rodrigo93 ) In my opinion this is not
the way to improve our codebase. The question could we rename the method (or
other code element) to something more descriptive had not been asked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
