Github user nlivens commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39961184
  
    --- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
 ---
    @@ -454,6 +563,80 @@ protected boolean applyACLRules(Network network, 
List<? extends InternalIdentity
         }
     
         @Override
    +    public boolean applyNetworkACLs(Network config, List<? extends 
NetworkACLItem> rules) throws ResourceUnavailableException {
    --- End diff --
    
    Since this is an overridden method from a base class, we can not change the 
return type


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to