----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18978/#review37020 -----------------------------------------------------------
Ship it! Ship It! - Nitin Mehta On March 12, 2014, 6:48 p.m., Amogh Vasekar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18978/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 6:48 p.m.) > > > Review request for cloudstack and Nitin Mehta. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217 > > > Repository: cloudstack-git > > > Description > ------- > > Add APIs for ability to add new guest OS types, and their hypervisor specific > mappings. > The table guest_os_hypervisor is currently maintained but not used, and the > APIs reuse the same. > > > Diffs > ----- > > api/src/com/cloud/event/EventTypes.java > a5fc0f0f7d3492fc0775b4514e4a9f506acb1ed7 > api/src/com/cloud/server/ManagementService.java > 5fcf0b5fc5279193db4147607e9919433b2a56db > api/src/com/cloud/storage/GuestOS.java > 437cd37d1abaf131e09a294dfabbfe9e901af596 > api/src/com/cloud/storage/GuestOSHypervisor.java > f022722af04331b3feb9562683efa384b0ce5676 > api/src/org/apache/cloudstack/api/ApiCommandJobType.java > f27f001f868ffb0b8315f5468e67d2ec67db4306 > api/src/org/apache/cloudstack/api/ApiConstants.java > 0a3fafda312ab72fea96928e68e37f25790e431c > api/src/org/apache/cloudstack/api/ResponseGenerator.java > 1cb53886a7cd4262f6d5636af6679a17f6a86dcd > api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java > PRE-CREATION > client/tomcatconf/commands.properties.in > 879c58d63425369eb411325bf6d2fb9d7de9d77a > engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java > 8210abf8c3d3becdc2b7d092a382f4b06123b7dd > engine/schema/src/com/cloud/storage/GuestOSVO.java > 57b852953a9fe4caae31043b8a63e1df2ff28f9b > engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java > 651cfb56700857669fcfffd6b134358d2c4bb044 > engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java > be680dc3a50830a9cd17b5cd203cdbc2db3e8936 > server/src/com/cloud/api/ApiResponseHelper.java > 81bfe21ee819130957a6d3826417c1fdd4deba79 > server/src/com/cloud/server/ManagementServer.java > 3b5f5ff206a28acaca964b0b4efeeb30c8c05da8 > server/src/com/cloud/server/ManagementServerImpl.java > 663d4e505c5ff7acb215143bdf67f2e114912710 > setup/db/db/schema-430to440.sql ee4cf215fb777fcd46c5715d2b21ffe157692e2a > > Diff: https://reviews.apache.org/r/18978/diff/ > > > Testing > ------- > > Tested on local environment on master branch for the APIs, including some > edge cases. > Ran with findbugs and RAT to ensure no errors in added code > > > Thanks, > > Amogh Vasekar > >
