> On March 11, 2014, 7:04 p.m., Nitin Mehta wrote: > > api/src/org/apache/cloudstack/api/ApiConstants.java, line 165 > > <https://reviews.apache.org/r/18978/diff/3/?file=516592#file516592line165> > > > > Just os is confusing. Rather name it as guestosname and > > hypervisorguestosname ?
These are legacy names that conform to the existing names. > On March 11, 2014, 7:04 p.m., Nitin Mehta wrote: > > api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java, > > line 37 > > <https://reviews.apache.org/r/18978/diff/3/?file=516595#file516595line37> > > > > An option for adding the guest os for all versions ? This will break the semantics in the following case : 1. Admin adds mappings for all existing versions of hypervisor 2. CS upgrades / supports new version The DB will not have mapping for new version, and there is no method to find out if the admin had previously added mappings for all versions or only a subset. > On March 11, 2014, 7:04 p.m., Nitin Mehta wrote: > > server/src/com/cloud/server/ManagementServerImpl.java, line 2124 > > <https://reviews.apache.org/r/18978/diff/3/?file=516608#file516608line2124> > > > > dont you have to check that hypervisor belongs to one of the three > > types ? This is for list command. The check exists while adding a new mapping. Specifying an invalid hypervisor in list command will return an empty list - Amogh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18978/#review36825 ----------------------------------------------------------- On March 11, 2014, 6:47 p.m., Amogh Vasekar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18978/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 6:47 p.m.) > > > Review request for cloudstack and Nitin Mehta. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217 > > > Repository: cloudstack-git > > > Description > ------- > > Add APIs for ability to add new guest OS types, and their hypervisor specific > mappings. > The table guest_os_hypervisor is currently maintained but not used, and the > APIs reuse the same. > > > Diffs > ----- > > api/src/com/cloud/server/ManagementService.java > 24fad87ea0f0b8b76137d85bbdb325c4821b9722 > api/src/com/cloud/storage/GuestOS.java > 437cd37d1abaf131e09a294dfabbfe9e901af596 > api/src/com/cloud/storage/GuestOSHypervisor.java > f022722af04331b3feb9562683efa384b0ce5676 > api/src/org/apache/cloudstack/api/ApiConstants.java > 7b7f9ca6012de11d7887a9c3d32dc79932552969 > api/src/org/apache/cloudstack/api/ResponseGenerator.java > 1cb53886a7cd4262f6d5636af6679a17f6a86dcd > api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java > PRE-CREATION > client/tomcatconf/commands.properties.in > 879c58d63425369eb411325bf6d2fb9d7de9d77a > engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java > 8210abf8c3d3becdc2b7d092a382f4b06123b7dd > engine/schema/src/com/cloud/storage/GuestOSVO.java > 57b852953a9fe4caae31043b8a63e1df2ff28f9b > engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java > 651cfb56700857669fcfffd6b134358d2c4bb044 > engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java > be680dc3a50830a9cd17b5cd203cdbc2db3e8936 > server/src/com/cloud/api/ApiResponseHelper.java > 81bfe21ee819130957a6d3826417c1fdd4deba79 > server/src/com/cloud/server/ManagementServerImpl.java > 62faafc68b31a7612b9280741af6f6f0d9759bf3 > setup/db/db/schema-430to440.sql 0ded7a97fd9d0a50fc0c1efd490feb635c0f27f2 > > Diff: https://reviews.apache.org/r/18978/diff/ > > > Testing > ------- > > Tested on local environment on master branch for all APIs, including some > edge cases. > > > Thanks, > > Amogh Vasekar > >
