----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18978/#review36694 -----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java <https://reviews.apache.org/r/18978/#comment67759> There should be list by the id ? api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java <https://reviews.apache.org/r/18978/#comment67749> Uncomment this. engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java <https://reviews.apache.org/r/18978/#comment67751> shouldnt be a string engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java <https://reviews.apache.org/r/18978/#comment67750> Remove this if not required server/src/com/cloud/server/ManagementServerImpl.java <https://reviews.apache.org/r/18978/#comment67752> why the like thing ? server/src/com/cloud/server/ManagementServerImpl.java <https://reviews.apache.org/r/18978/#comment67753> Since this is mandatory this is not required. Check for others as well server/src/com/cloud/server/ManagementServerImpl.java <https://reviews.apache.org/r/18978/#comment67754> Put this in DaoImpl server/src/com/cloud/server/ManagementServerImpl.java <https://reviews.apache.org/r/18978/#comment67755> Add in the logging - "make sure the name is unique" server/src/com/cloud/server/ManagementServerImpl.java <https://reviews.apache.org/r/18978/#comment67756> put in .remove() - cant leave for the TODO server/src/com/cloud/server/ManagementServerImpl.java <https://reviews.apache.org/r/18978/#comment67757> Probably add a bit more info...that this is preset and cant be removed, though since its admin only I think it should be fine...say he doesnt want the windows vms to be deployed setup/db/db/schema-430to440.sql <https://reviews.apache.org/r/18978/#comment67758> hopefully the length is the standard as other tables are using it. Please confirm - Nitin Mehta On March 10, 2014, 7:22 p.m., Amogh Vasekar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18978/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 7:22 p.m.) > > > Review request for cloudstack and Nitin Mehta. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217 > > > Repository: cloudstack-git > > > Description > ------- > > Add APIs for ability to add new guest OS types, and their hypervisor specific > mappings. > The table guest_os_hypervisor is currently maintained but not used, and the > APIs reuse the same. > > > Diffs > ----- > > api/src/com/cloud/server/ManagementService.java > 24fad87ea0f0b8b76137d85bbdb325c4821b9722 > api/src/com/cloud/storage/GuestOS.java > 437cd37d1abaf131e09a294dfabbfe9e901af596 > api/src/com/cloud/storage/GuestOSHypervisor.java > f022722af04331b3feb9562683efa384b0ce5676 > api/src/org/apache/cloudstack/api/ApiConstants.java > 7b7f9ca6012de11d7887a9c3d32dc79932552969 > api/src/org/apache/cloudstack/api/ResponseGenerator.java > 1cb53886a7cd4262f6d5636af6679a17f6a86dcd > api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java > PRE-CREATION > client/tomcatconf/commands.properties.in > 879c58d63425369eb411325bf6d2fb9d7de9d77a > engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java > 8210abf8c3d3becdc2b7d092a382f4b06123b7dd > engine/schema/src/com/cloud/storage/GuestOSVO.java > 57b852953a9fe4caae31043b8a63e1df2ff28f9b > engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java > 651cfb56700857669fcfffd6b134358d2c4bb044 > engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java > be680dc3a50830a9cd17b5cd203cdbc2db3e8936 > server/src/com/cloud/api/ApiResponseHelper.java > 81bfe21ee819130957a6d3826417c1fdd4deba79 > server/src/com/cloud/server/ManagementServerImpl.java > 62faafc68b31a7612b9280741af6f6f0d9759bf3 > setup/db/db/schema-430to440.sql 0ded7a97fd9d0a50fc0c1efd490feb635c0f27f2 > > Diff: https://reviews.apache.org/r/18978/diff/ > > > Testing > ------- > > Tested on local environment on master branch for all APIs, including some > edge cases. > > > Thanks, > > Amogh Vasekar > >
