-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18068/#review34470
-----------------------------------------------------------
Ship it!
commit 7f90fb2a4403b1ec542026f1b30d1b05fcf68f95
Author: wrodrigues <wrodrig...@schubergphilis.com>
Date: Mon Feb 10 18:20:15 2014 +0100
adding fix and unit tests for cloud-engine-api scariest
Signed-off-by: Hugo Trippaers <htrippa...@schubergphilis.com>
- Hugo Trippaers
On Feb. 13, 2014, 12:08 p.m., Wilder Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18068/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 12:08 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding fixes and unit tests for cloud-engine-api scariest bugs found by
> FindBugs
>
>
> Diffs
> -----
>
>
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/type/VolumeTypeBase.java
> 78ac8e2
>
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/type/VolumeTypeHelper.java
> 5057203
>
> engine/api/test/org/apache/cloudstack/engine/subsystem/api/storage/type/VolumeTypeHelperTest.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18068/diff/
>
>
> Testing
> -------
>
> Build successful + 8 unit tests added to cover the changes
>
>
> Thanks,
>
> Wilder Rodrigues
>
>
