> On July 29, 2013, 8:45 p.m., Alena Prokharchyk wrote: > > 1) DataCenterVnetDaoImpl.java > > > > deleteRange method. > > > > List<String> vnets - this type is very ambigous. How is it represented? > > 100-200? 100,101,102,103? People are going to use this method, you either > > have to document it well, or use diff datastructure. > > > > 2) Not able to re-set the range back to NULL > > > > 3) The main concern: > > > > createPhysicalNetwork should work just as updatePhysicalNetwork. Right now > > it fails: > > > > http://localhost:8096/?command=createPhysicalNetwork&name=200&vlan=1-2,6-100&zoneId=1 > > > > <createphysicalnetworkresponse cloud-stack-version="4.2.0-SNAPSHOT"> > > <errorcode>431</errorcode> > > <cserrorcode>4350</cserrorcode> > > <errortext>Please specify valid integers for the vlan range.</errortext> > > </createphysicalnetworkresponse>
fixed these issues. - bharat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/#review24171 ----------------------------------------------------------- On July 30, 2013, 8:46 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12905/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 8:46 a.m.) > > > Review request for cloudstack, Alena Prokharchyk and Sheng Yang. > > > Bugs: Cloudstack-3753 > > > Repository: cloudstack-git > > > Description > ------- > > https://issues.apache.org/jira/browse/CLOUDSTACK-3753 > Multiple VLAN range API need to accept a list rather than "add" or "remove" > per command > > > Diffs > ----- > > api/src/com/cloud/network/NetworkService.java 59ccdbf > > api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java > 333564e > engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 > engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 > server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca > server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a > server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a > server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 > > Diff: https://reviews.apache.org/r/12905/diff/ > > > Testing > ------- > > Tested on master. > removed the removevlan parameter. > vlan parameter can be used for both addition and removal of valns. > instead of passing only a vlan range. user has to pass all the vlan ranges > that he wants to keep. > the vlan ranges missing in the input and present in the db (not allocated) > will be removed. > > > Thanks, > > bharat kumar > >
