----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/#review24182 -----------------------------------------------------------
Also the response format is incorrect. The vlan ranges have to be separated by ",", not by ";". It should be just the way they are specified in the API request. Right now it looks like this: <listphysicalnetworksresponse cloud-stack-version="4.2.0-SNAPSHOT"> <count>1</count> <physicalnetwork> <id>8fd221e4-71a6-478b-9b30-76e6714a855c</id> <name>ZONE1-pNtwk</name> <broadcastdomainrange>ZONE</broadcastdomainrange> <zoneid>325066e1-db7c-45b8-87e7-155af0e3cba3</zoneid> <state>Disabled</state> <vlan>1-2;4-4;6-100</vlan> </physicalnetwork> </listphysicalnetworksresponse> - Alena Prokharchyk On July 26, 2013, 4:17 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12905/ > ----------------------------------------------------------- > > (Updated July 26, 2013, 4:17 a.m.) > > > Review request for cloudstack, Alena Prokharchyk and Sheng Yang. > > > Bugs: Cloudstack-3753 > > > Repository: cloudstack-git > > > Description > ------- > > https://issues.apache.org/jira/browse/CLOUDSTACK-3753 > Multiple VLAN range API need to accept a list rather than "add" or "remove" > per command > > > Diffs > ----- > > api/src/com/cloud/network/NetworkService.java 59ccdbf > > api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java > 333564e > engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 > engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 > server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca > server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a > server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a > server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 > > Diff: https://reviews.apache.org/r/12905/diff/ > > > Testing > ------- > > Tested on master. > removed the removevlan parameter. > vlan parameter can be used for both addition and removal of valns. > instead of passing only a vlan range. user has to pass all the vlan ranges > that he wants to keep. > the vlan ranges missing in the input and present in the db (not allocated) > will be removed. > > > Thanks, > > bharat kumar > >
