Hi Alena, The code as of now works with a valn siting having ranges separated by semicolons(it is like this now 2001-2003;2012-2013, I will update it to work with comas.
rather than compare each range with the existing one we have used sets to figure out what to add and and what to remove. On Jul 25, 2013, at 4:26 AM, Alena Prokharchyk <alena.prokharc...@citrix.com<mailto:alena.prokharc...@citrix.com>> wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ 1) Bharat, can you please check if your API allows you to set the vnet range with the multiple ranges. The command syntax should be like this - vnets should be specified and separated by comma: http://localhost:8096/?command=updatePhysicalNetwork&id=200&vlan=2001-2010,2012-2013 2) Also I find it very confusing that you are continuing to store the vnet field in physical_network table. Once the ranges were introduced, you should have moved them to the separate data structure as its very hard to update/validate the String representation as every single time you have to * split the ranges * validate each range against the new range you pass in - Alena Prokharchyk On July 24th, 2013, 9:57 p.m. UTC, bharat kumar wrote: Review request for cloudstack, Alena Prokharchyk and Sheng Yang. By bharat kumar. Updated July 24, 2013, 9:57 p.m. Bugs: Cloudstack-3753 Repository: cloudstack-git Description https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than "add" or "remove" per command Testing Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Diffs * api/src/com/cloud/network/NetworkService.java (59ccdbf) * api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java (333564e) * engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java (e2e6b79) * engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java (ced2982) * server/src/com/cloud/network/NetworkServiceImpl.java (f1f71ca) * server/test/com/cloud/network/MockNetworkManagerImpl.java (4577d0a) * server/test/com/cloud/network/UpdatePhysicalNetworkTest.java (e3fc36a) * server/test/com/cloud/vpc/MockNetworkManagerImpl.java (fd61bc6) View Diff<https://reviews.apache.org/r/12905/diff/>
