The usage in the trie memtable is only for volatile access to buffers. In this case I chose the library instead of reimplementing the functionality (e.g. as methods in `ByteBufferUtil`) because the relevant interface makes sense and the library is a good quality one that contains a range of other utilities that can be very useful to Cassandra.
In other words, I personally would welcome opening Cassandra up to using other parts of Agrona, and am asking if the community shares this sentiment. Regards, Branimir On Wed, Sep 21, 2022 at 9:15 PM Derek Chen-Becker <de...@chen-becker.org> wrote: > Agrona looks like it has quite a bit more than just buffers, so if we add > this as a dependency for the new memtable, would it potentially open up use > of other parts of Agrona (wittingly or not)? Unless I misunderstood, wasn't > part of the new memtable implementation an interface to allow this to be > pluggable? Could we avoid bringing it in as a full dependency for Cassandra > if the trie memtable were packaged separately as a plugin instead of being > included directly? > > Cheers, > > Derek > > On Wed, Sep 21, 2022 at 6:41 AM Benedict <bened...@apache.org> wrote: > >> In principle no, it’s a high quality library. But it might help to >> briefly outline what it’s used for. I assume it is instead of ByteBuffer? >> In which case it could maybe be worthwhile discussing as a project how we >> foresee interaction with existing buffer machinery, and maybe how we expect >> our buffer use to evolve on the project, as we already have several buffers. >> >> That said, I anticipate our buffer use changing significantly with the >> introduction of value types and native memory improvements coming in future >> Java releases, so my personal inclination is just to accept the dependency. >> >> On 21 Sep 2022, at 13:29, Branimir Lambov <blam...@apache.org> wrote: >> >> >> Hi everyone, >> >> CASSANDRA-17240 (Trie memtable implementation) introduces a dependency on >> the agrona library (https://github.com/real-logic/agrona). >> >> Does anyone have any objections to adding this dependency? >> >> Regards, >> Branimir >> >> > > -- > +---------------------------------------------------------------+ > | Derek Chen-Becker | > | GPG Key available at https://keybase.io/dchenbecker > <https://urldefense.com/v3/__https://keybase.io/dchenbecker__;!!PbtH5S7Ebw!cY9TyIm1RqAGMkhgyKDjzQcOq6Cy6kzMj_VjvMm40JG9VMm6JgFfH9omG1Spx0UmlkEcGJcFmDtKjcbIGBN7PBunbg$> > and | > | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org > <https://urldefense.com/v3/__https://pgp.mit.edu/pks/lookup?search=derek*40chen-becker.org__;JQ!!PbtH5S7Ebw!cY9TyIm1RqAGMkhgyKDjzQcOq6Cy6kzMj_VjvMm40JG9VMm6JgFfH9omG1Spx0UmlkEcGJcFmDtKjcbIGBPzYoayyA$> > | > | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | > +---------------------------------------------------------------+ > > -- Branimir Lambov e. branimir.lam...@datastax.com w. www.datastax.com
