+1 to David and Benedict's sentiments here. Probably a good habit for us to get into in general (including the "why" when hitting up ML about a new dep)
On Wed, Sep 21, 2022, at 1:29 PM, David Capwell wrote: > I am +1 to adding, good library, but agree with Benedict it would be good to > know “why”. > >> On Sep 21, 2022, at 5:40 AM, Benedict <bened...@apache.org> wrote: >> >> >> In principle no, it’s a high quality library. But it might help to briefly >> outline what it’s used for. I assume it is instead of ByteBuffer? In which >> case it could maybe be worthwhile discussing as a project how we foresee >> interaction with existing buffer machinery, and maybe how we expect our >> buffer use to evolve on the project, as we already have several buffers. >> >> That said, I anticipate our buffer use changing significantly with the >> introduction of value types and native memory improvements coming in future >> Java releases, so my personal inclination is just to accept the dependency. >> >> >>> On 21 Sep 2022, at 13:29, Branimir Lambov <blam...@apache.org> wrote: >>> >>> Hi everyone, >>> >>> CASSANDRA-17240 (Trie memtable implementation) introduces a dependency on >>> the agrona library (https://github.com/real-logic/agrona). >>> >>> Does anyone have any objections to adding this dependency? >>> >>> Regards, >>> Branimir
