On Mon, Jun 22, 2020 at 3:23 AM Benedict Elliott Smith <bened...@apache.org> wrote: > > If you read the clauses literally there's no conflict - not all committers > that +1 the change need to review the work. It just means that two > committers have indicated they are comfortable with the patch being merged. > One of the +1s could be based on another pre-existing review and trust in > both the contributor's and reviewer's knowledge of the area; and/or by > skimming the patch. Though they should make it clear that they did not > review the patch when +1ing, so there's no ambiguity.
Ah, I understand now, thank you Benedict for explaining. If I understand correctly the intention is that all patches must be ~"deeply understood" by at least two contributors (author + reviewer) and one of those contributors must be a comitter. In addition, at least two committers must support the patch being merged not necessarily having done a detailed review. I like the phrase "+1. I support this patch" vs a "+1 I have reviewed this patch and support it". I suppose that if the +1 is coming from a person in the reviewer field the "I have reviewed it" is perhaps implicit. > Perhaps we should elaborate on the document to avoid this confusion, as this > has come up multiple times. I was confused but now I think I understand it and agree with you that the wording is not in conflict. After the document is finalized I can add a FAQ section and, if people think it reasonable, to https://cassandra.apache.org/doc/latest/development/how_to_commit.html . -Joey --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
