rajvarun77 commented on PR #3330: URL: https://github.com/apache/brpc/pull/3330#issuecomment-4697085796
This is ready for review and merge. The branch is up to date with master (the #3310 merge conflict is resolved) and `mergeable`. The only failing checks are the three bazel unittest jobs, all on the **same unrelated** target `//test:brpc_channel_unittest` (78/79 pass in each): - `clang-unittest-with-bazel` / `gcc-unittest-with-bazel` — `brpc_channel_unittest` TIMEOUT at 300s - `clang-unittest-bazel-with-babylon-and-new-pb` — `ChannelTest.backup_request_policy` failed This is a pre-existing timing flake, not related to this PR's diff. The failing assertion is `test/brpc_channel_unittest.cpp:2208` — a 100 ms hang-guard on socket teardown — which overshot by <1 ms (100,896 µs) under bazel's parallel execution + 300 s per-test cap on the 2-vCPU runner. The same test passes in the serial make/cmake unittest jobs (`clang-unittest` and `clang-unittest-asan` are green), and the MySQL tests this PR touches all run and pass there (auth handshake 28 / packet 27 / scramble 35). @chenBright @wwbmmm @yanglimingcn — could you take a look and merge when you have a moment? Happy to open a separate follow-up for the `brpc_channel_unittest` flake/timeout if useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
