rajvarun77 commented on PR #3330: URL: https://github.com/apache/brpc/pull/3330#issuecomment-4665061753
@wwbmmm @chenBright — heads-up on CI: the two `*-unittest-with-bazel` lanes show one failure, and it is an unrelated flake, not a regression from this PR. - The failing target is `//test:brpc_channel_unittest`, and within it a single timing-sensitive case, `ChannelTest.backup_request`, hung and blew the 300s test timeout (the timeout stack trace points at `ChannelTest::TestBackupRequest()`). It is a timeout, not an assertion failure. - The **same commit passes** that test in the make lanes (`clang-unittest` and `clang-unittest-asan` are green), and **all seven `//test:mysql/*` targets pass** in the bazel lanes. - It is independent of this change: the new flags use `_flags` bits 14/15 while backup-request uses `FLAGS_BACKUP_REQUEST` (bit 5) — no collision — and the backup-request path never touches `bind_sock_action()`. A re-run of the failed jobs should clear it (I cannot trigger re-runs as an outside contributor). This PR is ready for another look whenever you have time: all review threads are addressed (I left one reply on `_fd_version` explaining why it stays atomic), the mysql integration suites now run against a real CI-provisioned mysqld, and I verified all seven suites locally against a live MySQL 9.6 (110 tests, 0 skipped, 0 failed). Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
